Reskin | App Layout and Header
#1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replaced `useDisplayName` with `useDAOName` to show dao name when found.
Da-Colon
changed the title
Reskin | App Layout and Header [Part 1]
✅ Deploy Preview for fractal-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The results popup, when searching for a DAO, renders inside the header component, making it get much larger than intended. 
... but before I submitted this comment, I went ahead and tried to fix it. Think i got something good enough. 
edit: I'm just now noticing the note in this PR
edit2: aaaand you've already implemented that next set up changes in a follow up branch/pr! Undoing the hacky thing I did in favor of the better code you wrote @Da-Colon |
adamgall
approved these changes
Apr 22, 2024
adamgall
force-pushed
the
reskin/1560-app-layout-0
branch
from
e8df5a6 to
d1b3e2c
Compare
`Reskin` | App Layout and Header [Part 2]
DarksightKellar
approved these changes
Apr 23, 2024
| px={8} | ||
| pt={8} | ||
| > | ||
| <Divider color="chocolate.700" /> |
There was a problem hiding this comment.
Is this a leftover colour that needs to be removed?
| > | ||
| <DrawerOverlay /> | ||
| <DrawerContent | ||
| bg="chocolate.900" |
There was a problem hiding this comment.
Is this a leftover colour that needs to be removed?
DarksightKellar
changed the title
Reskin | App Layout and Header [Part 1]Reskin | App Layout and Header
mudrila
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buttonvariant, Icon and position.Next PR
Wallet MenucomponentsFavorites MenucomponentsSearch Bar PopupcomponentsIssue
Works on #1560
Screenshot
Blurred Content:
